-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "fbask_jan16_sticky" realization to livestock module #678
add "fbask_jan16_sticky" realization to livestock module #678
Conversation
The main intended effect of the realization is that it provides more stability to the livestock production, in scenarios of more liberal trade. The largest differences are visible when using superregions (with completly free trade within each superregion), but the effect can also be seen to some extend with normal h12 magpie. (unfortunately the h16s5 preprocessing using a superregion depends on the newest mrcommons version which doesn't run with the develop at the moment) Here are plots of a default h12 run (without landconversion costs and yield calibration from a calibration run) with and without the new realization. In contrast to the default I used See From all the shiny results of the relevant livestock variables I always only show those variables and regions where significant differences do occur: |
The only warnings/errors from the GAMS model run I got where:
I think these errors are unrelated to the new realization. They also do not stop the execution of the GAMS code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Found just one typo.
Co-authored-by: Jan Dietrich <[email protected]>
I decided to do another evaluation of the new realization with more more extreme settings, to show in which direction the effects go. The following plots are with the settings:
So we have a higher capital need, a lower depreciation of stocks and a very free trade. Of course these settings are unrealistic but they serve to show how the main effect of using the realization: It then takes time to build up capital stocks and production is not so easily shifted away from regions when capital stocks are already build up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a s70_multiplicator_capital_need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the s70_multiplicator_capital_need
multiplikator to reflect uncertainty that we may have in the capital need (LN75 of preloop).
So the default capital need is such that multiplied with the sum of interest rate and depreciation rate it equals the capital factor requirements. This means it strongly depends on the depreciation rate which is also configurable and a global estimate.
In general my guess would be that it is not so easy to estimate the capital need from the VoP, capital share, interest and depreciation rates. (Correct me if i'm wrong!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good and very cool to me! I am missing the difference in run time with the implementation activated, and it is not so clear why a s70_multiplicator_capital_need is needed.
Thank you very much for the review and comment! There was no significant difference in the runtime 19,5 min with the realization 20 min without (only checked for the first of the two test runs i did). |
🐦 Description of this PR 🐦
This PR adds the
fbask_jan16_sticky
realization to the livestock module. It is a "sticky" version of thefbask_jan16
realization, that uses the (simplified) methodology of thesticky_feb18
factor cost realization for it's factor costs calculation.The documentation describes the difference to
fbask_jan16
as follows:🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly